Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

allow sublcasses as parameters (#1285) #1441

Merged
WonderCsabo merged 15 commits into from
Jun 4, 2015
Merged

allow sublcasses as parameters (#1285) #1441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1ae4956
add isTypeOrSubclass() and castArgumentIfNecessary() helper to Abstr…
dodgex Jun 4, 2015
9f6a665
allow Preference subclasses as parameter for @PreferenceChange and @P…
dodgex Jun 4, 2015
26649ab
add test for subclass parameters on @PreferenceClick and @PreferenceC…
dodgex Jun 4, 2015
e304701
allow subclasses for @CheckedChange
dodgex Jun 4, 2015
993fd40
add test for subclasses in @CheckedChange
dodgex Jun 4, 2015
ffafaef
allow subclasses for @Click
dodgex Jun 4, 2015
8d475a7
add test for subclasses in @Click
dodgex Jun 4, 2015
75b6c1f
allow subclasses for @EditorAction
dodgex Jun 4, 2015
bce352b
add test for subclasses in @EditorAction
dodgex Jun 4, 2015
f35b750
allow subclasses for @FocusChange
dodgex Jun 4, 2015
00b0df5
add test for subclasses in @FocusChange
dodgex Jun 4, 2015
e89b710
allow subclasses for @LongClick
dodgex Jun 4, 2015
c02c4b1
add test for subclasses in @LongClick
dodgex Jun 4, 2015
760a246
allow subclasses for @Touch
dodgex Jun 4, 2015
8f95477
add test for subclasses in @Touch
dodgex Jun 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow subclasses for @longclick
  • Loading branch information
@dodgex
dodgex committed Jun 4, 2015
commit e89b71067ce3e58f405420f66bfa02e8533b7156
9 changes: 7 additions & 2 deletions ...ns/androidannotations-api/src/main/java/org/androidannotations/annotations/LongClick.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
* The method MAY have one parameter:
* </p>
* <ul>
* <li>A {@link android.view.View} parameter to know which view has been long
* clicked</li>
* <li>A {@link android.view.View} (or a subclass) parameter to know which view
* has been long clicked</li>
* </ul>
*
* <blockquote>
Expand All @@ -59,6 +59,11 @@
* // Something Here
* }
*
* &#064;LongClick
* void <b>myButton</b>LongClicked(Button view) {
* // Something Here
* }
*
* &#064;LongClick(<b>R.id.myButton</b>)
* boolean longClick<b>Consumed</b>OnMyButton(View view) {
* return true;
Expand Down
4 changes: 2 additions & 2 deletions ...ons/androidannotations/src/main/java/org/androidannotations/handler/LongClickHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void validate(Element element, AnnotationElements validatedElements, IsVa

validatorHelper.returnTypeIsVoidOrBoolean(executableElement, valid);

validatorHelper.param.type(CanonicalNameConstants.VIEW).optional().validate(executableElement, valid);
validatorHelper.param.extendsType(CanonicalNameConstants.VIEW).optional().validate(executableElement, valid);
}

@Override
Expand All @@ -72,7 +72,7 @@ protected void processParameters(EComponentWithViewSupportHolder holder, JMethod
boolean hasViewParameter = parameters.size() == 1;
JVar viewParam = listenerMethod.param(classes().VIEW, "view");
if (hasViewParameter) {
call.arg(viewParam);
call.arg(castArgumentIfNecessary(holder, CanonicalNameConstants.VIEW, viewParam, parameters.get(0)));
}
}

Expand Down