Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Checkstyle #1198

Merged
yDelouis merged 5 commits into from
Dec 27, 2014
Merged

Checkstyle #1198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edf3791
Add checkstyle
WonderCsabo Aug 29, 2014
bc99f07
Update license plugin
WonderCsabo Oct 19, 2014
f82dc91
Check JavaDoc with Checkstyle for all annotations
WonderCsabo Oct 20, 2014
f643816
Move Checkstyle execution to a separate profile for Travis
WonderCsabo Oct 20, 2014
11e5621
Adding @return to all method JavaDoc
WonderCsabo Oct 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move Checkstyle execution to a separate profile for Travis 
It can be really annoying for contributors for always fixing the code
due to broken build by Checkstyle even before starting implementing a
feature. That's why the Checkstyle execution is moved to a separate
profile what will be used by Travis CI. Contributors are still
encouraged to run Checkstyle manually before pushing code, but Travis
will reject malformatted code in the PRs anyway.
  • Loading branch information
@WonderCsabo
WonderCsabo committed Dec 22, 2014
commit f643816642a45696900f76deb20ed2991154547a
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ before_script:
- export TERM=dumb

script:
- mvn -f AndroidAnnotations/pom.xml install
- mvn -f AndroidAnnotations/pom.xml install -P travis
- mvn -f examples/maveneclipse/pom.xml install -Dandroidannotations.version=3.3-SNAPSHOT
- ./examples/gradle/gradlew build --build-file examples/gradle/build.gradle

Expand Down
29 changes: 18 additions & 11 deletions AndroidAnnotations/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,17 +315,6 @@
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down Expand Up @@ -364,6 +353,24 @@
</plugins>
</build>
</profile>
<profile>
<id>travis</id>
<build>
<plugins>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<phase>process-sources</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<reporting>
Expand Down