This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
Extend RestErrorHandler to catch NestedRuntimeException - #1006
Merged
DayS merged 1 commit intoMay 31, 2014
Merged
Conversation
…springframework.core.NestedRuntimeException
toshe
changed the title
toshe
changed the title
DayS
added a commit
that referenced
this pull request
May 31, 2014
Extend RestErrorHandler to catch NestedRuntimeException
Contributor
|
Seems legit :) Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #1002 -
RestErrorHandlershould not be limited toRestClientException. When there is a network problem (SocketTimeoutException,HttpHostConnectExceptionor an exception thrown by Jackson) Spring's RestTemplate automatically throws aResourceAccessException. We should be able to handle those exceptions as well.ResourceAccessExceptionandRestClientExceptionare both subclasses ofNestedRuntimeException.I have not changed the method name
onRestClientExceptionThrownin order to ensure backwards compatibility. Current users implementingRestErrorHandlershould not face any problems, even when catching the exceptions manually prior to handling them, since they are all subclasses ofNestedRuntimeException.