Bean with @RootContext Activity in a singleton #674

Activity

1. DayS commented on Jul 25, 2013

   

   DayS

   on Jul 25, 2013

   Contributor

   More actions

   Ho. That one was tricky :)

   Just to clarify this point, let's assume we have the following classes :

   @EActivity
   public class MyActivity extends Activity {
       @Bean
       MySingletonBean mySingletonBean;
   }
   
   @EBean(scope = Scope.Singleton)
   public class MySingletonBean {
       @Bean
       MyBean myBean;
   }
   
   @EBean
   public class MyBean {
       @RootContext
       Activity activity;
   }

   As the context stored in a singleton bean is always the application context, and the @RootContext checks if the instance of context matches the field type before injecting it, we have the following situation :

   1. MyActivity is a context of type Activity
   2. MySingletonBean takes the Activity and stored the ApplicationContext from it
   3. MyBean takes the ApplicationContext and doesn't inject the context because we want an Activity

   Dunno what we should do for this. Throwing an exception will be a pain in the ass if the developer needs to do this. Moreover, it'll break the API, as we just not setting the field right now.
2. tbruyelle commented on Jul 25, 2013

   

   tbruyelle

   on Jul 25, 2013

   ContributorAuthor

   More actions

   @DayS Yes it is exactly the situation you described. I'm not sure if it's really tricky, that just happened to me multiple times (or maybe a I have strange way to use AA!)

   What I really dislike in this issue is the fact that an annotated field is not injected silently. But you're right it'll break the API to throw an exception. But I don't have a better solution for now...
3. yDelouis commented on Jul 25, 2013

   

   yDelouis

   on Jul 25, 2013

   Contributor

   More actions

   We could just add a log explaining why the Activity has not been injected.
4. DayS commented on Jul 25, 2013

   

   DayS

   on Jul 25, 2013

   Contributor

   More actions

   The log might be the best solution.
5. DayS commented on Sep 23, 2013

   

   DayS

   on Sep 23, 2013

   Contributor

   More actions

   This was merged. I'm closing this issue then
6. DayS

   closed this as completedon Sep 23, 2013