This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Multiple findViewById calls when setting listener for field #580
Description
Code generated for settings listeners isn't the most efficient one. Sample generated code looks like that:
private void afterSetContentView_() {
myButton = ((Button) findViewById(id.button1));
{
View view = findViewById(id.button1);
if (view!= null) {
view.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View view) {
PictureList_.this.button1();
}
}
);
}
}
}
I'm guessing that is hard to know that myButton is the same button we are generating listener for. Maybe it would by good idea to replace findViewById method with some custom method that would use SparseArray to cache references?
Activity
DayS commentedon May 16, 2013
This is a good idea, mostly on a complex
ViewGroupwith lots ofView.I think, we can (and we should) do that directly at compile time. We just need to keep
ViewByIdProcessorrunning before all other listeners processor.I'll take a look on this
DayS commentedon May 17, 2013
I just see that the issue #552 is about the same thing.
MikolajKakol commentedon May 17, 2013
Sorry for duplication, I searched for them but didn't find similar issue.