You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
findViewById called twice when using @ItemClick (and similar) on injected View #552
When having a View injected (@ViewById) and also ataching an ItemClick Listener (@ItemClick), the findViewById method is called twice in the generated afterSetContentView_ method.
The downside is that findViewById is not a very cheap method, is it?
Example:
Class:
public class Class{
...
@ViewById
protected View placesList;
@ItemClick(R.id.placesList)
public void editPlace(Place place){}
...
}
As said in #580 this could be a good idea.
We can (and we should) do that directly at compile time. We just need to keep ViewByIdProcessor running before all other listeners processor.
When having a View injected (@ViewById) and also ataching an ItemClick Listener (@ItemClick), the findViewById method is called twice in the generated afterSetContentView_ method.
The downside is that findViewById is not a very cheap method, is it?
Example:
Class:
Generated:
Thanks and keep doing the great work you are doing!