Repository navigation
Providing MessageConverter for RestTemplate #206
Description
@royclarkson just let me know that the RestTemplate default constructor now comes with no MessageConverters, for performance reasons.
It's quite obvious that no one needs all the default converters, we usually only need one converter.
This change also means that by default, a @Rest annotated interface will come with en empty RestTemplate that will have no MessageConverter. To add one, we must do: restClient.getRestTemplate().getMessageConverters().add(new MappingJacksonHttpMessageConverter());
We should provide a new annotation (or a new attribute) to let users specify the MessageConverters.
@Rest
@Converters({MappingJacksonHttpMessageConverter.class, XmlAwareFormHttpMessageConverter.class})
public interface RestClient {
}We should check that they have a default constructor. We could also allow classes annotated with @EBean, but I'm not sure this would provide much added value for now.
Activity
royclarkson commentedon May 25, 2012
It is still possible to create a new RestTemplate instance with the default set of converters by calling RestTemplate(true). As you note, there isn't a lot of need for loading all of these though. For reference, these are the default converters that are loaded:
pyricau commentedon May 26, 2012
Thank your for those details. We could also detect the availability of the libs in the classpath at compile time and automatically add the converters in such a case, but I think we'd rather let the users fail early, find out that they need to add specific converters & libs, and then only add the needed ones.
I added a RestTemplate section to the documentation to document this new RestTemplate behavior. Thanks again for letting us know!
a-thomas commentedon May 31, 2012
We can let the two ways:
@Converters, then we use the default RestTemplate constructor@Converters, then we add the provided ones.pyricau commentedon May 31, 2012
Well, since the default
RestTemplateconstructor is now the one that comes with no converters, there's no "two ways" here :) . They'll both use the same constructor.Provided HttpMessageConverters for RestTemplate. See #206
Adding converters() param to @rest and renaming value() to rootUrl().…