This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Method based @ViewsById isEmpty() #1966
Description
I've tried to used method based @ViewsById method, but found out that method parameter is empty List.
This happens beacuse of wrong order of calls in generated code.
I've also noticed that test of this part of code is incorrect.
AndroidAnnotations version:
4.2.0
Android compile SDK version:
25
Annotated code:
@ViewsById({R.id.divider_1, R.id.divider_2, R.id.divider_3, R.id.short_cut_container})
void init(List<View> views) {
...
}Expected generated code:
@Override
public void onViewChanged(HasViews hasViews) {
ArrayList<View> list_init_views = new ArrayList<View>();
View view_divider_1 = hasViews.findViewById(R.id.divider_1);
View view_divider_2 = hasViews.findViewById(R.id.divider_2);
View view_divider_3 = hasViews.findViewById(R.id.divider_3);
View view_short_cut_container = hasViews.findViewById(R.id.short_cut_container);
if (view_divider_1 != null) {
list_init_views.add(view_divider_1);
}
if (view_divider_2 != null) {
list_init_views.add(view_divider_2);
}
if (view_divider_3 != null) {
list_init_views.add(view_divider_3);
}
if (view_short_cut_container!= null) {
list_init_views.add(view_short_cut_container);
}
{
List<View> views = null;
views = list_init_views;
init(views);
}
}Actual generated code:
@Override
public void onViewChanged(HasViews hasViews) {
ArrayList<View> list_init_views = new ArrayList<View>();
View view_divider_1 = hasViews.findViewById(R.id.divider_1);
View view_divider_2 = hasViews.findViewById(R.id.divider_2);
View view_divider_3 = hasViews.findViewById(R.id.divider_3);
View view_short_cut_container = hasViews.findViewById(R.id.short_cut_container);
{
List<View> views = null;
views = list_init_views;
init(views);
}
if (view_divider_1 != null) {
list_init_views.add(view_divider_1);
}
if (view_divider_2 != null) {
list_init_views.add(view_divider_2);
}
if (view_divider_3 != null) {
list_init_views.add(view_divider_3);
}
if (view_short_cut_container!= null) {
list_init_views.add(view_short_cut_container);
}
}Metadata
Metadata
Assignees
Labels
No labels
Activity
dodgex commentedon Mar 7, 2017
Thank you for your detailed report. I'll investigate this asap.
miszmaniac commentedon Mar 7, 2017
I was about to make PR, but I didn't manage to configure project:)
I'm not sure if the instructions are up-to-date:)
dodgex commentedon Mar 7, 2017
AFAIK the contribution guide should be up to date.
where do you have trouble?
miszmaniac commentedon Mar 7, 2017
I can't run functional tests (basically compile tests also, but mvnw install starts tests also
https://github.com/androidannotations/androidannotations/wiki/InstallingEnvironment#running-the-functional-tests
I got Error:Android Source Generator: [androidannotations] AndroidManifest.xml file not found
I've changed those preferences of paths to support /src/main/, so I Have no idea why that is:)
dodgex commentedon Mar 8, 2017
Have you configured intellij to use the correct folders? (see here)