This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
copy javadoc for Activity @Extra and @FragmentArg to thier builder #1525
Description
if it is possible to read javadoc comments from processed elements/fields it would be nice to copy the javadoc for Activity @Extra and @FragmentArg to the related builder. that allows to have a documented "api".
e.g.
/**
* [any javadoc]
*/
@Extra("MY_EXTRA_KEY")
protected String myExtra;->
/**
* [any javadoc]
*/
public MyActivity_.IntentBuilder_ myExtra(long myExtra) {
return super.extra(MY_EXTRA, myExtra);
}dependeing on the possibilities of the code generation extend the javadoc to be valid:
/**
* [any javadoc]
*
* @param myExtra The value to set
* @return The IntentBuilder to chain calls
*/thoughts?
Activity
dodgex commentedon Aug 19, 2015
maybe even generate the javadoc all the time, but add the text from the field ?
yDelouis commentedon Aug 19, 2015
Shall we count on you to submit a PR as soon as the project is not frozen due to the plugin refacto any more ?
dodgex commentedon Aug 19, 2015
If this enhancement is welcome i'll try to get a PR up. Any eta on the plugin refactoring?
yDelouis commentedon Aug 19, 2015
It's hard to give an ETA for the plugin refacto but I think we are close to the end. All it remains, I think, is to define the API for plugins.
dodgex commentedon Aug 19, 2015
Okay, so I still got some time for this PR. ;)
WonderCsabo commentedon Aug 19, 2015
dodgex commentedon Aug 19, 2015
@WonderCsabo it passes.
dodgex commentedon Aug 19, 2015
is there another annotation beside
@Extraand@FragementArgthat creates a method for a builder?WonderCsabo commentedon Aug 22, 2015
dodgex commentedon Aug 23, 2015
@ServiceActionuses the same code to generate the methods as@Extraso there is the javadoc with the@paramand@returnalready. only having additional custom javadoc text is not possible there as the setter methods are generated by parametersWonderCsabo commentedon Sep 1, 2015
Great, thanks for looking into this!
WonderCsabo commentedon Sep 15, 2015
Implemented.