This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
dataScheme (and other) for @Receiver[Action] #1176
Description
as @ReceiverAction is now merged into develop i thought if it would make sense to add features like dataSchemes similar to @Receiver :)
the annotation would then get an String[] dataSchemes() and the generated code could be somewhat like
public final static List<String> SAMPLE_RECEIVER_SCHEMES = Arrays.asList("http","https");
public final static String SAMPLE_RECEIVER_ACTION = "ACTION";
public final static String ANY_EXTRA = "EXTRA";
@Override
public void onReceive(Context context, Intent intent) {
context_ = context;
super.onReceive(context, intent);
String action = intent.getAction();
String scheme = intent.getScheme();
if (SAMPLE_RECEIVER_ACTION.equals(action) && SAMPLE_RECEIVER_SCHEMES.contains(scheme)) {
Bundle extras = intent.getExtras();
if (extras!= null) {
KeyEvent anyExtra = extras.getParcelable(ANY_EXTRA);
super.sampleReceiverAction(context, anyExtra);
}
return ;
}
}but as mentioned, i'm not yet sure if this is needed. personally i haven't used any dataScheme in a Receiver yet. but it might still be insteresting.
it this is considered usefull, maybe we should also consider adding some of the other intent filter features e.g. mime type or categories (maybe there are others too). i'm not very deep into BroadcastReceiver related stuff so i can not decide how usefull these features are but they might be usefull in other apps than mine. ;)
Activity
WonderCsabo commentedon Oct 5, 2014
I think the most important feature which is now can be considered missing would be
@Receiver.Extra.@OnActivityResultand@ReceiverActionboth has the@Extrafield, but@Receivernot. Opened #1180 for that.WonderCsabo commentedon Oct 6, 2014
Thanks. I think the next thing would be adding
dataSchemesto@ReceiverActionas well for parity.About
categoryandmime typei am not sure which one is the more widely used. @yDelouis any thoughts?yDelouis commentedon Oct 6, 2014
I'm ok with adding
dataSchemes.About
categoryandmime type, let's wait for someone to ask us to add them.dodgex commentedon Oct 7, 2014
okay. i'll try to get a PR for
dataSchemesin@ReceiverActionup asap.i agree with waiting until someone asks for
categoryandmimetype. :)dodgex commentedon Oct 9, 2014
@WonderCsabo @yDelouis is there any specific reason why the
camelCaseToUpperSnakeCaseremoves numbers from the string?i had a
test()and atest2()method, both tried to get aACTION_TESTconstant due to this number removal. i think the numbers should not be removed.WonderCsabo commentedon Oct 9, 2014
Did you check what calls that method?
dodgex commentedon Oct 9, 2014
it is called by a hand full of handler have not checked it in detail. havent seen anything that looked like "whoop no i dont want numbers here". just came up with the above thougth.
WonderCsabo commentedon Nov 8, 2014
I am closing this since there was no comment about the other two since a month. Thanks @dodgex for your work!