This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
@Receiver never called with OnAttachOnDetach + local #1132
Description
LocalBroadcastManager can't register the IntentFilter because the IntentFilter.addAction() called in onCreate AFTER onAttach (where the filter added to the manager). The filter is empty when AA try to register the action in manager. Therefore the action won't be registered.
Activity
dodgex commentedon Sep 10, 2014
@westito why do you need the registration in onAttach? wouldn't onCreate or start/resume be enough?
@WonderCsabo any idea? we could check if an
IntentFilter/@Receivershould be registred in onAttach and then setup the filter there. but this could bring issues to the caching if we are not carefull, as we currently only care about the actions and dataSchemes.actually i would suggest to consider removing the onAttach registration options. first it is only available to
Fragmentsand second onCreate is called right after onAttach so there shouldn't be any issues with registration after create instead of attach.WonderCsabo commentedon Sep 10, 2014
@yDelouis is the author of this feature, so i think he should decide. Personally, I would not drop
OnAttachOnDetachsince it is already implemented, only if fixing this is too hard.WonderCsabo commentedon Nov 8, 2014
@westito @dodgex can one of you guys look into the fix for this?
dodgex commentedon Nov 10, 2014
currently i don't have much time as i'm busy with my own project. i'll try to take a look at this as soon as the update i'm working on is done.
WonderCsabo commentedon Dec 23, 2014
Any news on this one?
dodgex commentedon Dec 23, 2014
yeah, sorry for the delay. totaly forgot this one. :(
WonderCsabo commentedon Mar 22, 2015
Fixed.