Remove postId from Show and Tell revalidation calls - #1455

@alok0 is attempting to deploy a commit to the Alveus Team on Vercel.

A member of the Team first needs to authorize it.

@pjeweb do you recall why we make a secondary API call here, rather than calling res.revalidate directly?

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
alveusgg-website	Ready	Preview	Sep 15, 2025 9:08pm

@pjeweb do you recall why we make a secondary API call here, rather than calling res.revalidate directly?

premature optimization? honestly not sure. i think it should just work directly

Might be because the revalidate call is deep in the database code?

Yeh that's true, though I don't see why the revalidateCache method couldn't call revalidatePath from next/cache twice instead of the fetch it currently calls.

Edit: Actually, does using the methods from next/cache work when this is in the pages router?

Want to try that as part of this to remove another moving piece, or just land this for now given we know its a no-op change?

It looks like the only places where it would be called are from trpc.

Sweet. Having looked at this logic more, I'm not really sure this'll change anything as these params were a no-op, but this at least cleans the logic up to make it a bit easier to trace what is happening.

The only potential time saved here is removing:

postIdOrIds.forEach((postId) =>
  url.searchParams.append("postId", postId),
);

I know from experience (nodejs/node#51518 + nodejs/node#51520) that URL.searchParams can be really expensive, though my fix has been in Node.js for a while (I don't think any other runtime has adopted this optimization though).

Failed to compile.
./src/server/db/show-and-tell.ts
Error:   x You're importing a component that needs "revalidatePath". That only works in a Server Component which is not supported in the pages/ directory. Read more: https://nextjs.org/docs/app/building-your-application/rendering/server-components
  |
   ,-[/vercel/path0/apps/website/src/server/db/show-and-tell.ts:2:1]
 1 | import { TRPCError } from "@trpc/server";
 2 | import { revalidatePath } from "next/cache";
   :          ^^^^^^^^^^^^^^
 3 | import { z } from "zod";
 4 | 
 5 | import {
   `----
Import trace for requested module:
./src/server/db/show-and-tell.ts
./src/pages/show-and-tell/map.tsx
> Build failed because of webpack errors
 ELIFECYCLE  Command failed with exit code 1.

RIP. I guess if we want to do this, we'll need to either pass through revalidate from res in the tRPC router, or call it directly in the tRPC router mutation definitions?

Very much a nit, but can we always do res: NextApiResponse rather than resp? Where res collides, I think the existing variables can be renamed to smth like data and still hold the same meaning?

Pushed this up to preview. @pjeweb would you mind giving this a test tomorrow?

Pushed this up to preview. @pjeweb would you mind giving this a test tomorrow?

on it now