Skip to content

feat: Add k-means clustering - #27

Merged
64json merged 1 commit into
algorithm-visualizer:masterfrom
Jeff-Tian:master
Jan 28, 2021
Merged

64json merged 1 commit into
algorithm-visualizer:masterfrom
Jeff-Tian:master

Conversation

@Jeff-Tian

Copy link
Copy Markdown
Contributor

Hi there!

I'd like to add a new algorithm k-means clustering to this repo, is it appropriate to merge? Please help review, thanks in advance!

The new visualizer needs an extra Scatter Chart, so there are relevant PRs to other repos, please help review them, too.

image

@64json
64json merged commit 7138698 into algorithm-visualizer:master Jan 28, 2021
@HairlessVillager

Copy link
Copy Markdown

Hey, gay! Could you please add commas at the end of lines? There are so many errors!

@Jeff-Tian

Copy link
Copy Markdown
Contributor Author

Hey, gay! Could you please add commas at the end of lines? There are so many errors!

Hi gay! Where are the errors? Could you share a screenshot of them?

@HairlessVillager

Copy link
Copy Markdown

I'm sorry, actually it's ;.

image

@Jeff-Tian

Copy link
Copy Markdown
Contributor Author

I don't think they are errors, and semicolons are optional. But it's good to add them to be consistent with the style in this repo. You could fork and add them and then make a PR. 🥇

@HairlessVillager

Copy link
Copy Markdown

Let's forget it. There is no big problem even if it is not changed. I'm feeling lazy now.😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants