Repository navigation
ABCs should import from collections.abc in Py3.7+ - #3275
Merged
asvetlov merged 2 commits intoSep 18, 2018
Merged
Conversation
augustogoulart
force-pushed
the
py37-collections-warning
branch
from
September 18, 2018 10:51
e6febc6 to
e370563
Compare
augustogoulart
changed the title
asvetlov
approved these changes
Sep 18, 2018
Member
|
thanks |
Contributor
Author
|
My pleasure. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
pyba-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In Python 3.8, importing ABCs directly from the
collectionsmodule will not be supported anymore.The proposed changes will stop the current warnings for the users working with Python 3.7 and prevent backward incompatibility.
python/cpython#5460
Are there changes in behavior for the user?
No.
Related issue number
#3273
PR #3258 also fixed some imports.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.