Skip to content

Fix build command: build-agones-sdk-image - #2603

Merged
roberthbailey merged 2 commits into
agones-dev:mainfrom
govargo:fix-make-build-sdk
May 31, 2022
Merged

Fix build command: build-agones-sdk-image#2603
roberthbailey merged 2 commits into
agones-dev:mainfrom
govargo:fix-make-build-sdk

Conversation

@govargo

@govargo govargo commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / Why we need it:

I found that agones-sdk image build command failed when I tried to test make run-sdk-conformance-test.
The command has changed, but it seems to have leaked in #2521.

Before this PR

% make ensure-agones-sdk-image
/Library/Developer/CommandLineTools/usr/bin/make ensure-image IMAGE_TAG=gcr.io/agones-images/agones-sdk:1.24.0-11f7c21-linux-amd64 BUILD_TARGET=build-agones-sdk-server-image
Could not find gcr.io/agones-images/agones-sdk:1.24.0-11f7c21-linux-amd64 image. Building...
make[2]: *** No rule to make target `build-agones-sdk-server-image'.  Stop.
make[1]: *** [ensure-image] Error 2
make: *** [ensure-agones-sdk-image] Error 2

BUILD_TARGET=build-agones-sdk-server-image is defined, but it doesn't exist.
The correct one is build-agones-sdk-image.

After this PR

% make ensure-agones-sdk-image
/Library/Developer/CommandLineTools/usr/bin/make ensure-image IMAGE_TAG=gcr.io/agones-images/agones-sdk:1.24.0-8062a04-linux-amd64 BUILD_TARGET=build-agones-sdk-image
Could not find gcr.io/agones-images/agones-sdk:1.24.0-8062a04-linux-amd64 image. Building...
mkdir -p ~/.kube/
mkdir -p /Users/xxxxx/go/src/agones.dev/agones/build//.gocache
mkdir -p /Users/xxxxx/go/src/agones.dev/agones/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
docker run --privileged --rm tonistiigi/binfmt:qemu-v6.2.0 --install arm64
...

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@Ludea

Ludea commented May 30, 2022

Copy link
Copy Markdown
Contributor

You save my day ! I'm on it since 2h -_-'

@agones-bot

agones-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

Build Failed 😱

Build Id: 309caa33-c7f2-4419-a680-3fd13ebed9db

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@Ludea

Ludea commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

lgtm
I apply this PR into #2591
And CI is green !

@google-oss-prow google-oss-prow Bot added the lgtm label May 31, 2022
@google-oss-prow

google-oss-prow Bot commented May 31, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-prow

google-oss-prow Bot commented May 31, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot

agones-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator

Build Succeeded 👏

Build Id: f7697487-c5bd-4b40-9c76-10cf09a5248a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2603/head:pr_2603 && git checkout pr_2603
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-7eef6ae-amd64

@roberthbailey
roberthbailey merged commit bb4c4c1 into agones-dev:main May 31, 2022
@govargo
govargo deleted the fix-make-build-sdk branch June 4, 2022 07:21
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
@SaitejaTamma SaitejaTamma added the kind/bug These are bugs. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp
1 more reviewer
@roberthbailey roberthbailey roberthbailey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@roberthbailey roberthbailey

Labels

approved kind/bug These are bugs. size/XS

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@govargo @Ludea @agones-bot @roberthbailey @SaitejaTamma