Skip to content

Corrected spelling error: Issue #2293 - #2294

Merged
roberthbailey merged 1 commit into
agones-dev:mainfrom
vaibhavp1964:patch-2
Oct 6, 2021
Merged

Corrected spelling error: Issue #2293#2294
roberthbailey merged 1 commit into
agones-dev:mainfrom
vaibhavp1964:patch-2

Conversation

@vaibhavp1964

@vaibhavp1964 vaibhavp1964 commented Oct 6, 2021 •
edited by roberthbailey
Loading

Copy link
Copy Markdown
Contributor

Corrected spelling error in site documentation.

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2293

Special notes for your reviewer:

@vaibhavp1964
Corrected spelling error: Issue agones-dev#2293
a21b55f 
Corrected spelling error in site documentation.
@google-cla google-cla Bot added the cla: yes label Oct 6, 2021
@agones-bot

agones-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

Build Failed 😱

Build Id: 84cb8db2-1a11-4db3-a9e1-d9d51b9baf14

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey

roberthbailey commented Oct 6, 2021

Copy link
Copy Markdown

Look like I flaky test (I filed an issue).

@google-oss-robot

google-oss-robot commented Oct 6, 2021

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, vaibhavp1964

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot

agones-bot commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

Build Succeeded 👏

Build Id: 4fa0e3b3-b22d-443b-a6ba-293e31f4c140

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2294/head:pr_2294 && git checkout pr_2294
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-a21b55f

@roberthbailey

roberthbailey commented Oct 6, 2021

Copy link
Copy Markdown

Even though we are in code freeze, since this is a fix to the website I'm going to merge it.

@roberthbailey
roberthbailey merged commit eb42918 into agones-dev:main Oct 6, 2021
@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 6, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 6, 2021
@roberthbailey roberthbailey mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pooneh-m pooneh-m Awaiting requested review from pooneh-m
1 more reviewer
@roberthbailey roberthbailey roberthbailey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@roberthbailey roberthbailey

Labels

approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

Spelling Error

4 participants

@vaibhavp1964 @agones-bot @roberthbailey @google-oss-robot