Skip to content

Fixed broken link to pass tests. - #1633

Merged
markmandel merged 1 commit into
agones-dev:masterfrom
devloop0:master
Jun 19, 2020
Merged

markmandel merged 1 commit into
agones-dev:masterfrom
devloop0:master

Conversation

@devloop0

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Fixes a broken link in a markdown file so that make test passes.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@devloop0

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@markmandel markmandel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devloop0, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jun 19, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 19, 2020
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 👏

Build Id: dbe05076-5b44-4529-a1cc-ce56b305f8f6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1633/head:pr_1633 && git checkout pr_1633
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-b84fed7

@markmandel
markmandel merged commit f1df165 into agones-dev:master Jun 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Nikhil Athreya <nathreya@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants