Conversation
tannewt
requested changes
Oct 1, 2026
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Testing is super helpful on its own.
Comment on lines
+9
to
+10
| FLASH_MODE = dio | ||
| FLASH_SIZE = 4MB |
Member
There was a problem hiding this comment.
Try it without these. They shouldn't be needed.
Comment on lines
+1
to
+12
| # Force Flash 4MB | ||
| CONFIG_ESPTOOLPY_FLASHSIZE_4MB=y | ||
| CONFIG_ESPTOOLPY_FLASHSIZE="4MB" | ||
| CONFIG_ESPTOOLPY_FLASHSIZE_8MB=n | ||
| CONFIG_ESPTOOLPY_FLASHMODE_QIO=y | ||
| CONFIG_ESPTOOLPY_FLASHFREQ_80M=y | ||
|
|
||
| # Disable PSRAM (absent on C5FH4) | ||
| CONFIG_SPIRAM=n | ||
|
|
||
| # Native USB Serial / JTAG console | ||
| CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG=y |
Member
There was a problem hiding this comment.
These should be implied by the settings in mpconfigboard.mk.
Removed redundant FLASH_MODE and FLASH_SIZE definitions.
Let's try to have more flash space.
This code:
import os; s = os.statvfs('/'); print(f"Total: {s[0]*s[2]/1048576:.2f} MB | Free: {s[0]*s[3]/1048576:.2f} MB")
Was reporting 1,17 MB before this change.
Removed specific flash and PSRAM configurations in favor of defaults.
Fix to MANUFACTURE to Waveshare Reorg the variable Make use of all flash on 4MB board
Make sure we have board.DISPLAY available.
Help define board.DISPLAY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider this for first review...
This has been vibe coded with Gemini using as base espressif_esp32c5_devkitc_1_n8r8 for the C5 support and waveshare_esp32_c5_lcd_1_47 for the LCD support. Works for me (even if it deserve more tests).
RGB is working, Wifi kind of work and show me my 5G wifi.
Web Workflow has been tested and I uploaded library with circup.
The screen is initialized and show the REPL.
I did not test the microSD yet.
Some settings are either conservative or just contradictory between what is in
sdkconfigand inmpconfigboard.mk, like should I use dio or qio, is the Flash frequency right?Why am I using both
CIRCUITPY_ESP_FLASH_MODEandFLASH_MODE?Or
CIRCUITPY_ESP_FLASH_SIZEandFLASH_SIZE... one of each should be the only one needed.And it could have some improvement such as adding:
CIRCUITPY_4MB_FLASH_LARGE_USER_FS_LAYOUT = 1 (should I)
I have so many questions on the code produced, human review or better LLM review is welcome.