Skip to content

Improved logging during setup #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konradpabjan merged 3 commits into from
Jul 15, 2020
Merged

Improved logging during setup #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
533746a
Improved error output during setup
konradpabjan Jul 15, 2020
afa9f9f
Change from debug to info for normal output
konradpabjan Jul 15, 2020
6fd8fd8
Apply suggestions from code review
konradpabjan Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change from debug to info for normal output
  • Loading branch information
@konradpabjan
konradpabjan committed Jul 15, 2020
commit afa9f9fbc99ce02ce3919f136c4e74d1b8586bab
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ You should specify only a major and minor version if you are okay with the most

Python distributions are only available for the same [environments](https://github.com/actions/virtual-environments#available-environments) that GitHub Actions hosted environments are available for. If you are using an unsupported version of Ubuntu such as `19.04` or an alternative Linux distribution such as Fedora, `setup-python` will not work. If you have a supported `self-hosted` runner and you would like to use `setup-python`, there are a few extra things you need to make sure are set up so that new versions of Python can be downloaded and configured on your runner.
Comment thread
konradpabjan marked this conversation as resolved.
Outdated

If you are experience problems while configuring python on your self-hosted runner. Turn on [step debugging](https://github.com/actions/toolkit/blob/main/docs/action-debugging.md#step-debug-logs) to see addition logs.
If you are experience problems while configuring python on your `self-hosted` runner. Turn on [step debugging](https://github.com/actions/toolkit/blob/main/docs/action-debugging.md#step-debug-logs) to see addition logs.
Comment thread
konradpabjan marked this conversation as resolved.
Outdated

### Windows

Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6355,7 +6355,7 @@ function installPython(workingDirectory) {
silent: true,
listeners: {
stdout: (data) => {
core.debug(data.toString().trim());
core.info(data.toString().trim());

@brcrista brcrista Jul 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

},
stderr: (data) => {
core.error(data.toString().trim());
Expand Down
2 changes: 1 addition & 1 deletion src/install-python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async function installPython(workingDirectory: string) {
silent: true,
listeners: {
stdout: (data: Buffer) => {
core.debug(data.toString().trim());
core.info(data.toString().trim());
},
stderr: (data: Buffer) => {
core.error(data.toString().trim());
Expand Down