Skip to content

Migrate Zulu distribution to new metadata API with CRaC support #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbauma109 wants to merge 12 commits into from
Closed

Migrate Zulu distribution to new metadata API with CRaC support #998

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
78111dc
Initial plan
Claude Apr 3, 2026
a06c8ec
Migrate Zulu distribution to new metadata API with CRaC support
Claude Apr 3, 2026
3f583bc
Fix redundant ternary expression in getAvailableVersions
Claude Apr 4, 2026
48d05a6
Fix P1 issues: Add pagination and correct architecture mapping for Zu…
Claude Apr 4, 2026
bb2f571
Fix codex P1 issues: Remove TCK filter for EA and use aarch64 for ARM64
Claude Apr 4, 2026
d44c72f
Fix test expectations: x64→arch=x64, arm64→arch=aarch64, EA releases …
Copilot Apr 4, 2026
7f63f5d
Fix JetBrains test: mock HttpClient.prototype.head to avoid real netw…
Copilot Apr 4, 2026
3721876
Revert JetBrains test mock: use real network calls now that cloudfron…
Copilot Apr 4, 2026
a7b700f
Minimize diff: remove unnecessary helper methods and inline logic
Claude Apr 4, 2026
f542c1c
Revert "Minimize diff" - restore helper methods per feedback
Claude Apr 4, 2026
3140bcf
Update __tests__/data/zulu-windows.json
nbauma109 Apr 4, 2026
301143a
Address copilot warnings: fix unused abi var, add pagination test, do…
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert JetBrains test mock: use real network calls now that cloudfron… 
…t.net is whitelisted

Agent-Logs-Url: https://github.com/nbauma109/setup-java/sessions/74ae64af-1192-420c-8c3e-aefa09bfb00a

Co-authored-by: nbauma109 <9403560+nbauma109@users.noreply.github.com>
  • Loading branch information
@nbauma109
Copilot and nbauma109 authored Apr 4, 2026
commit 3721876b1b2a9841d65f7b0d1d03eaadc1101ab2
11 changes: 4 additions & 7 deletions __tests__/distributors/jetbrains-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import {HttpClient} from '@actions/http-client';
import {JetBrainsDistribution} from '../../src/distributions/jetbrains/installer';

import manifestData from '../data/jetbrains.json';
import os from 'os';

describe('getAvailableVersions', () => {
let spyHttpClient: jest.SpyInstance;
let spyHttpClientHead: jest.SpyInstance;

beforeEach(() => {
spyHttpClient = jest.spyOn(HttpClient.prototype, 'getJson');
Expand All @@ -15,10 +15,6 @@ describe('getAvailableVersions', () => {
headers: {},
result: []
});
spyHttpClientHead = jest.spyOn(HttpClient.prototype, 'head');
spyHttpClientHead.mockReturnValue({
message: {statusCode: 200}
});
});

afterEach(() => {
Expand All @@ -44,8 +40,9 @@ describe('getAvailableVersions', () => {
const availableVersions = await distribution['getAvailableVersions']();
expect(availableVersions).not.toBeNull();

// manifestData items + 2 hidden versions (always included when head is mocked to return 200)
expect(availableVersions.length).toBe(manifestData.length + 2);
const length =
os.platform() === 'win32' ? manifestData.length : manifestData.length + 2;
expect(availableVersions.length).toBe(length);
}, 10_000);
});

Expand Down