Skip to content

Add GitHub Token Support for GraalVM and Refactor Code #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-HarithaVattikuti merged 14 commits into from
Nov 18, 2025
Merged

Add GitHub Token Support for GraalVM and Refactor Code #849

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6992528
Code updated to let code accept github token and refactored the code.
v-mahabaleshwars Jun 6, 2025
4c9e711
github token accept through environment variable
v-mahabaleshwars Jul 3, 2025
7f499ce
fix test error
v-mahabaleshwars Jul 3, 2025
eb1a878
audit fix commit
v-mahabaleshwars Sep 9, 2025
6593b7e
Merge branch 'main' into fix/graalvm-api-rate-limit
v-mahabaleshwars Sep 9, 2025
cb55b3e
update package-lock.json
v-mahabaleshwars Sep 9, 2025
f5b041c
Merge remote-tracking branch 'origin/main' into fix/graalvm-api-rate-…
v-mahabaleshwars Sep 9, 2025
70ede9d
Update GraalVM Tests
v-mahabaleshwars Sep 15, 2025
a55d8d1
Lint Issue Resolve
v-mahabaleshwars Sep 15, 2025
bac80db
Update Test case for Windows
v-mahabaleshwars Sep 15, 2025
cc4f61c
Merge remote-tracking branch 'origin/main' into fix/graalvm-api-rate-…
v-mahabaleshwars Oct 6, 2025
ba6d721
Merge remote-tracking branch 'origin/main' into fix/graalvm-api-rate-…
v-mahabaleshwars Oct 29, 2025
bcde537
update with enhance code and test
v-mahabaleshwars Oct 29, 2025
67460fe
Merge remote-tracking branch 'origin/main' into fix/graalvm-api-rate-…
v-mahabaleshwars Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Test case for Windows
  • Loading branch information
@v-mahabaleshwars
v-mahabaleshwars committed Sep 15, 2025
commit bac80db521946ffd9f3ee647e171765e93887b76
52 changes: 43 additions & 9 deletions __tests__/distributors/graalvm-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ describe('GraalVMDistribution', () => {

expect(jest.isMockFunction(tc.downloadTool)).toBe(true);
expect(jest.isMockFunction(tc.cacheDir)).toBe(true);

jest.restoreAllMocks();
jest.clearAllMocks();
});

describe('getPlatform', () => {
Expand Down Expand Up @@ -101,9 +104,11 @@ describe('GraalVMDistribution', () => {
(tc.cacheDir as jest.Mock).mockResolvedValue('/cached/java/path');

(util.extractJdkFile as jest.Mock).mockResolvedValue('/tmp/extracted');
(util.renameWinArchive as jest.Mock).mockImplementation(
(p: string) => p + '.renamed'
);

// Mock renameWinArchive - it returns the same path (no renaming)
// But it appears the implementation might not even call this
(util.renameWinArchive as jest.Mock).mockImplementation((p: string) => p);

(util.getDownloadArchiveExtension as jest.Mock).mockReturnValue('tar.gz');

(fs.readdirSync as jest.Mock).mockReturnValue(['graalvm-jdk-17.0.5']);
Expand All @@ -116,44 +121,73 @@ describe('GraalVMDistribution', () => {
it('should download, extract and cache the tool successfully', async () => {
const result = await (distribution as any).downloadTool(javaRelease);

// Verify the download was initiated
expect(tc.downloadTool).toHaveBeenCalledWith(javaRelease.url);

// The implementation uses the original path for extraction
expect(util.extractJdkFile).toHaveBeenCalledWith(
'/tmp/archive.tar.gz',
'/tmp/archive.tar.gz', // Original path
'tar.gz'
);

// Verify directory reading
expect(fs.readdirSync).toHaveBeenCalledWith('/tmp/extracted');

// Verify caching with correct parameters
expect(tc.cacheDir).toHaveBeenCalledWith(
path.join('/tmp/extracted', 'graalvm-jdk-17.0.5'),
'Java_GraalVM_jdk',
'17.0.5',
'x64'
);

// Verify the result
expect(result).toEqual({
version: '17.0.5',
path: '/cached/java/path'
});

// Verify logging
expect(core.info).toHaveBeenCalledWith(
'Downloading Java 17.0.5 (GraalVM) from https://example.com/graalvm.tar.gz ...'
);
expect(core.info).toHaveBeenCalledWith('Extracting Java archive...');
});

it('should verify Windows-specific rename logic', () => {
it('should verify that renameWinArchive is available but may not be called', () => {
// Just verify the mock is set up correctly
const originalPath = '/tmp/archive.tar.gz';
const renamedPath = '/tmp/archive.tar.gz.renamed';

(util.renameWinArchive as jest.Mock).mockReturnValue(renamedPath);

// Call the mock directly to verify it works
const result = util.renameWinArchive(originalPath);

expect(result).toBe(renamedPath);
// Verify it returns the same path (no renaming)
expect(result).toBe(originalPath);
expect(util.renameWinArchive).toHaveBeenCalledWith(originalPath);
});

it('should handle different archive extensions', async () => {
// Test with a .zip file
(util.getDownloadArchiveExtension as jest.Mock).mockReturnValue('zip');
(tc.downloadTool as jest.Mock).mockResolvedValue('/tmp/archive.zip');

const zipRelease = {
version: '17.0.5',
url: 'https://example.com/graalvm.zip'
};

const result = await (distribution as any).downloadTool(zipRelease);

expect(util.extractJdkFile).toHaveBeenCalledWith(
'/tmp/archive.zip',
'zip'
);

expect(result).toEqual({
version: '17.0.5',
path: '/cached/java/path'
});
});
});

describe('findPackageForDownload', () => {
Expand Down
Loading