Skip to content

Add an error condition for non jdk Microsoft OpenJDK build #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-shibanov merged 3 commits into from
Dec 21, 2021
Merged

Add an error condition for non jdk Microsoft OpenJDK build #265

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b802aa
throw error for non jdk package type
dmitry-shibanov Dec 16, 2021
af683f3
change error to the warning
dmitry-shibanov Dec 17, 2021
f185ccd
change warning to error
dmitry-shibanov Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13889,6 +13889,10 @@ class MicrosoftDistributions extends base_installer_1.JavaBase {
if (!this.stable) {
throw new Error('Early access versions are not supported');
}
if (this.packageType !== 'jdk') {
this.packageType = 'jdk';
core.warning('Microsoft Build of OpenJDK always uses the `jdk` package type. Remove the `java-package` argument when calling the action to silence this warning.');
}
const availableVersionsRaw = yield this.getAvailableVersions();
const opts = this.getPlatformOption();
const availableVersions = availableVersionsRaw.map(item => ({
Expand Down
11 changes: 11 additions & 0 deletions docs/advanced-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,17 @@ steps:
- run: java -cp java HelloWorldApp
```

### Microsoft
```yaml
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v2
with:
distribution: 'microsoft'
java-version: '11'
- run: java -cp java HelloWorldApp
```

## Installing custom Java package type
```yaml
steps:
Expand Down
7 changes: 7 additions & 0 deletions src/distributions/microsoft/installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ export class MicrosoftDistributions extends JavaBase {
throw new Error('Early access versions are not supported');
}

if (this.packageType !== 'jdk') {
Comment thread
brcrista marked this conversation as resolved.
this.packageType = 'jdk';
core.warning(
'Microsoft Build of OpenJDK always uses the `jdk` package type. Remove the `java-package` argument when calling the action to silence this warning.'
);
}

const availableVersionsRaw = await this.getAvailableVersions();

const opts = this.getPlatformOption();
Expand Down