Skip to content

Draft: Fix API URL on GHES #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshmgross wants to merge 11 commits into from
Closed

Draft: Fix API URL on GHES #437

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4793596
Add integration test to validate `base-url`
joshmgross Nov 16, 2023
8df72cd
Fix URLs in base url integration test
joshmgross Nov 16, 2023
b7d983c
Remove trailing `/` from inputs
joshmgross Nov 16, 2023
0a6deda
Fix bash script
joshmgross Nov 16, 2023
28e4318
Only set base URL when input is defined
joshmgross Nov 16, 2023
df3133d
Add debug logging for base URL
joshmgross Nov 16, 2023
98dabfb
Try without base-url entirely
joshmgross Nov 16, 2023
ec76ce5
Include GraphQL URL validations
joshmgross Nov 16, 2023
4cc0320
Default to server URL explicitly
joshmgross Nov 16, 2023
85717e4
Use API URL instead of Server URL
joshmgross Nov 16, 2023
d09af74
Avoid setting baseURL if the input is not provided
joshmgross Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix URLs in base url integration test
  • Loading branch information
@joshmgross
joshmgross committed Nov 16, 2023
commit 8df72cd04ec2fbbf929bb78ad7d2f71b03c0ad95
16 changes: 8 additions & 8 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ jobs:
name: base-url set
uses: ./
with:
base-url: https://my.github-enterprise-server.com/api/v3
base-url: https://my.github-enterprise-server.com/api/v3/
script: |
const endpoint = github.request.endpoint
return endpoint({}).url
Expand All @@ -276,26 +276,26 @@ jobs:
name: base-url does not override GITHUB_API_URL when not set
uses: ./
env:
GITHUB_API_URL: https://my.github-enterprise-server.com/api/v3
GITHUB_API_URL: https://my.github-enterprise-server.com/api/v3/
with:
script: |
const endpoint = github.request.endpoint
return endpoint({}).url
result-encoding: string
- run: |
echo "- Validating base-url default"
expected="https://api.github.com"
expected="https://api.github.com/"
if [[ "${{steps.base-url-default.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-default.outputs.result}}"
echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-default.outputs.result}}"
exit 1
fi
echo "- Validating base-url set to a value"
expected="https://my.github-enterprise-server.com/api/v3"
expected="https://my.github-enterprise-server.com/api/v3/"
if [[ "${{steps.base-url-set.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-set.outputs.result}}"
echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-set.outputs.result}}"
exit 1
fi
echo "- Validating base-url not set respects GITHUB_API_URL"
expected="https://my.github-enterprise-server.com/api/v3"
expected="https://my.github-enterprise-server.com/api/v3/"
if [[ "${{steps.base-url-env.outputs.result}}" != "$expected" ]]; then
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-env.outputs.result}}"
echo $'::error::\u274C' "Expected base-url to equal '$expected', got ${{steps.base-url-env.outputs.result}}"