Skip to content

Match CocoaPods names exactly when reading version lists #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Match CocoaPods names exactly when reading version lists #206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8684f
Match CocoaPods names exactly when reading version lists
codewithfourtix Sep 5, 2026
8f5c6f3
Address review feedback and strengthen regression coverage
codewithfourtix Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Match CocoaPods names exactly when reading version lists 
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
  • Loading branch information
@codewithfourtix
codewithfourtix committed Sep 5, 2026
commit 4a8684f286d075f7e091e26f30cda1cd7d10947d
2 changes: 1 addition & 1 deletion src/fetchcode/package_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def get_cocoapod_tags(spec, name):
data = response.strip()
for line in data.splitlines():
line = line.strip()
if line.startswith(name):
if line.startswith(name + "/"):
data_list = line.split("/")
if data_list[0] == name:
data_list.pop(0)
Expand Down
13 changes: 13 additions & 0 deletions tests/test_cocoapods_tag_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from fetchcode.package_util import get_cocoapod_tags


def test_cocoapod_tags_skip_packages_with_same_prefix(monkeypatch):
monkeypatch.setattr(
"fetchcode.utils.get_text_response", lambda url: "FooBar/9.0\nFoo/1.0/2.0\n"
)
assert get_cocoapod_tags("https://example.com/versions", "Foo") == ["1.0", "2.0"]


def test_cocoapod_tags_return_none_when_only_prefix_matches(monkeypatch):
monkeypatch.setattr("fetchcode.utils.get_text_response", lambda url: "FooBar/9.0\n")
assert get_cocoapod_tags("https://example.com/versions", "Foo") is None
Comment on lines +27 to +29