Conversation
As `aasm_fire_event` isn't a regular callback that can be defined.
|
Code Climate has analyzed commit 8de0393 and detected 0 issues on this pull request. View more on Code Climate. |
alto
reviewed
Jun 20, 2025
| ```ruby | ||
| event before_all_transactions | ||
| event before_transaction | ||
| event aasm_fire_event (within transaction) |
Member
There was a problem hiding this comment.
@ovedanner I do agree, the method aasm_fire_event shouldn't be mentioned here. But we still need an indicator to show that this is the time when the actual event is fire. Maybe replacing the line with
<event fired>
would help? What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way
aasm_fire_eventis currently listed kind of makes it look like a callback than can be defined, while it's not. I'm not sure if people need to be aware ofaasm_fire_eventat all.