Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint 4 [FIX] Backend fixes: UN-2900, UN-2902, UN-2953, UN-3038, UN-3133, UN-3176, UN-3333 #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Sprint 4 [FIX] Backend fixes: UN-2900, UN-2902, UN-2953, UN-3038, UN-3133, UN-3176, UN-3333 #2257
Changes from 1 commit
be9d774da198d0aa0df6faa4f086f45d4e0c8308801f8a4a768eaec4fc2962cdf75e3707ed225eb9ff6aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
…traction Single pass builds ONE combined prompt -- every field declared up front in a single JSON schema, answered in one LLM call -- so no prompt's output exists to feed another prompt's variable. The runtime reflects that: the enterprise single_pass_extraction plugin calls the shared replacement service with structured_output={}, and both replace_static_variable and replace_dynamic_variable return the prompt UNCHANGED when their lookup misses. The literal {{...}} is then sent to the LLM, silently degrading the answer. This is not specific to custom_data, despite the ticket title. CUSTOM_DATA is in fact the ONLY variable type that survives single pass, because it resolves from the tool's own custom_data and never consults the variable map. STATIC and DYNAMIC variables both fail on their own, with no custom_data involved: static : "check {{invoice_number}}" -> "check {{invoice_number}}" dynamic : "via {{https://.../x[cust_id]}}" -> unchanged custom : "{{custom_data.client.name}}" -> "Acme GmbH" (works) Adds find_unresolvable_single_pass_variables() and surfaces the result per prompt as single_pass_unresolvable_variables when the tool has single-pass enabled. Warning only -- deliberately NOT a save-time block, because existing projects may already carry this combination and users toggle single pass on and off; a hard refusal would break them retroactively and be order-dependent. Classification pairs with VariableReplacementService in the worker, which keeps its own copy of the variable regexes; noted in the docstring since drift would make validation and runtime disagree. Known gap: this covers Prompt Studio authoring, not an already-exported tool running single pass via API deployment, which keeps failing silently until the tool is re-saved. That argues for pairing this with placeholder-stripping at runtime later, not for widening this change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sXFBEu2GHatXq2CV2ShPFUh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing