Repository navigation
Sync spec to wefunder#23097 (GA promotions, investment changes) + quickstart-track examples - #1
Merged
Merged
Conversation
…hanges + quickstart-track examples Regenerated against wefunder greg/lithium/api-docs-landing @ 0a345d900e5 (PR #23097): - listCompanyInvestmentChanges is now public (internal -> ga): generated module _generated/api/investment_delta + a paginating example. - 34 beta ops promoted to ga (companies, follows, portfolio, syndicates + member management, statistics). No surface change: the SDK ships ga+beta. - User.id is a string (usr_...), reorderSyndicateMembers documents mem_ ids. Two new guide snippets mirror the docs landing page's quickstart tracks so the Python tab can use the SDK instead of raw httpx: - guides/user-token: PKCE -> exchange_code -> Wefunder(tokens=, store=) -> portfolio.get() - guides/install-target: list_eligible_install_targets -> create_installation -> (fallback: find the ACTIVE install by target, never by position -> create_installation_token) -> first request as the installation. ruff + pyright clean; 146 tests green (coverage/freshness/conformance). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…hrowing Review finding: the example called create_installation first and the "already installed" 409 propagated, so the fallback that mints a token for the existing install was unreachable. The API's 409 `already_installed` carries the existing install's id in details.installation (installations_controller.rb), so catch exactly that error, mint for that id, and continue; any other error (installation_revoked, missing scope) still raises. Adds tests/test_example_install_target.py: already-installed path (409 → mint → deals request runs AS the installation), and a different 409 still raises. pyright resolves examples/ via extraPaths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — companion to Wefunder/wefunder#23097 and wefunder-node#18. Re-sync (
python scripts/sync_spec.py) if that PR's spec changes again before merge; regenerated against its branch @0a345d900e5.Spec changes picked up
listCompanyInvestmentChangesis now public (internal → ga): generated modulewefunder._generated.api.investment_delta.list_company_investment_changes+ a paginating example.User.idis now a string (usr_…);reorderSyndicateMembersdocumentsmem_ids.New guide snippets (for the docs landing page)
guides/user-tokenexchange_code→Wefunder(tokens=…, client_id=…, store=…)→wf.portfolio.get()guides/install-targetlist_eligible_install_targets→create_installation→ fallback: find the active install by target (never by position) →create_installation_token→ first request as the installation(
guides/client-credentialsalready covers the explore track.)Verification
Once the docs add a
pythonentry toapi-docs/sdk-manifests.config.json(after the first tag), these samples land on the Python tab.🤖 Generated with Claude Code