REGRESSION(309394@main): [GLib] Web process launch aborts for unix: PULSE_SERVER values and abstract D-Bus addresses - #75651
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 60efd90) Details |
aperezdc
approved these changes
Oct 2, 2026
aperezdc
added
the
GLib Suggested Backport - 2.54
csaavedra
added
the
unsafe-merge-queue
…ULSE_SERVER values and abstract D-Bus addresses https://bugs.webkit.org/show_bug.cgi?id=326070 Reviewed by Adrian Perez de Castro. Two conversions from C string handling to spans in 309394@main lose information at the edges of the string: bindPulse() takes the socket path with span().subspan(5), which drops the null terminator, so UTF8CStringView::fromUTF8() fails its RELEASE_ASSERT and the UI process aborts as soon as a web process is launched with PULSE_SERVER=unix:/path. Take the subspan from spanIncludingNullTerminator(). directoryContainingDBusSocket() tests the result of StringView::find() for truth, but notFound is SIZE_MAX. For a unix: address without a path= component, such as the unix:abstract= addresses dbus-launch produces, the offset wraps to 4 and the function hands bubblewrap a relative path under the current directory, which does not exist. The xdg-dbus-proxy launch then fails and the UI process aborts with "Failed to fully launch dbus-proxy". Compare against notFound, restoring the pre-309394@main behaviour of binding nothing. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::bindPulse): (WebKit::directoryContainingDBusSocket): Canonical link: https://commits.webkit.org/322488@main
webkit-commit-queue
force-pushed
the
eng/GLib-Web-process-launch-aborts-for-unix-PULSE_SERVER-and-abstract-D-Bus-addresses
branch
from
October 2, 2026 13:12
60efd90 to
9f57a50
Compare
Collaborator
|
Committed 322488@main (9f57a50): https://commits.webkit.org/322488@main Reviewed commits have been landed. Closing PR #75651 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9f57a50
60efd90
🧪 ios-wk2-wpt🧪 mac-wk2