Unified build failure when compiling for iOS simulator debug - #75650

720bc3a

Unified build failure when compiling for iOS simulator debug
https://bugs.webkit.org/show_bug.cgi?id=326068
rdar://188997830

Reviewed by Youenn Fablet.

JSObject.h defines JSObject::setStructure() inline, and it calls
JSCell::setStructure(), which is only defined, always-inline in release, in
JSCellInlines.h. The cmake build emits every inline function in a prefix
header into a PCH object (-fpch-codegen). WebCorePrefix.h includes JSObject.h
but not JSCellInlines.h, so each WebCore PCH object referenced a
JSCell::setStructure() that no object file defines. The release iOS build
failed to link with an undefined symbol
`JSC::JSCell::setStructure(JSC::VM&, JSC::Structure*)`.

Move the definition of JSObject::setStructure() to StructureCreateInlines.h,
next to JSObject::didBecomePrototype(), which calls it. Declare it inline in
JSObject.h, have JSObjectInlines.h include StructureCreateInlines.h, and have
the bindings generator include StructureCreateInlines.h in constructors that
call setSubclassStructureIfNeeded().

* Source/JavaScriptCore/runtime/JSObject.h:
(JSC::JSObject::setStructure): Deleted.
* Source/JavaScriptCore/runtime/JSObjectInlines.h:
* Source/JavaScriptCore/runtime/StructureCreateInlines.h:
(JSC::JSObject::setStructure):
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
* Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:
* Source/WebCore/dom/ios/MouseEventIOS.cpp:

Canonical link: https://commits.webkit.org/322499@main

f1fc211

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	⏳ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 api-mac-debug	🧪 jsc-wpe
✅ 🧪 jsc-x86-64	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
✅ 🛠 🧪 jsc-debug-arm64	⏳ 🛠 ios-safer-cpp	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision		⏳ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	⏳ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim