REGRESSION(322476@main) [WPE] run-wpe-tests crashes with KeyError: 'LIBGL_ALWAYS_SOFTWARE' - #75647
Merged
webkit-commit-queue merged 1 commit intoOct 2, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash a3ae8d5) Details |
obyknovenius
added
the
New Bugs
nikolaszimmermann
approved these changes
Oct 2, 2026
nikolaszimmermann
requested changes
Oct 2, 2026
nikolaszimmermann
left a comment
nikolaszimmermann
left a comment
Contributor
There was a problem hiding this comment.
as discussed, this is wrong, the API tests silently switched to GPU...
Contributor
Author
This patch by itself doesn't switch anything. It just prevents the crash when |
clopez
approved these changes
Oct 2, 2026
nikolaszimmermann
added
the
unsafe-merge-queue
… 'LIBGL_ALWAYS_SOFTWARE' ` https://bugs.webkit.org/show_bug.cgi?id=326066 Reviewed by Carlos Alberto Lopez Perez. 322476@main changed `WPEPort.setup_environ_for_server()` to set `LIBGL_ALWAYS_SOFTWARE` only when the `gl_rendering_backend` option is `cpu`. That option is defined only by `run-webkit-tests`. Under `run-wpe-tests` it is `None`, so the variable is never set. `api_test_runner.py` assumes it is always present on WPE and removes it for WPE Platform tests with `pop()` and no default. GTK is not affected because `run-gtk-tests` has no WPE Platform tests. Add default value to `pop('LIBGL_ALWAYS_SOFTWARE')` to not raise `KeyError` when it is not set. * Tools/glib/api_test_runner.py: (TestRunner._run_test_glib): Canonical link: https://commits.webkit.org/322491@main
webkit-commit-queue
force-pushed
the
fix/glib/api-test-runner/libgl-always-software-exception
branch
from
October 2, 2026 13:25
a3ae8d5 to
23dcf60
Compare
Collaborator
|
Committed 322491@main (23dcf60): https://commits.webkit.org/322491@main Reviewed commits have been landed. Closing PR #75647 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
obyknovenius
deleted the
fix/glib/api-test-runner/libgl-always-software-exception
branch
October 2, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
23dcf60
a3ae8d5
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 api-mac-debug🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-intel-wk2