Conversation
cdumez
added
the
WebKit Misc.
Collaborator
|
EWS run on previous version of this PR (hash 858570e) Details |
webkit-ews-buildbot
added
the
merging-blocked
https://bugs.webkit.org/show_bug.cgi?id=326054 Reviewed by NOBODY (OOPS!). Fix Safer C++ warnings in Source/WebKitLegacy/mac/WebView and update the expectations accordingly. WebFeature and WebFormDelegate are renamed to Objective-C++ so that they can use smart pointers. * Source/WebKitLegacy/PlatformCocoa.cmake: * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: * Source/WebKitLegacy/mac/WebView/WebFeature.mm: Renamed from Source/WebKitLegacy/mac/WebView/WebFeature.m. * Source/WebKitLegacy/mac/WebView/WebFormDelegate.mm: Renamed from Source/WebKitLegacy/mac/WebView/WebFormDelegate.m. * Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.h: Add type traits. * Source/WebKitLegacy/mac/WebView/WebArchive.h: * Source/WebKitLegacy/mac/WebView/WebArchive.mm: * Source/WebKitLegacy/mac/WebView/WebFramePrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.h: * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: * Source/WebKitLegacy/mac/WebView/WebViewInternal.h: * Source/WebKitLegacy/mac/WebView/WebViewPrivate.h: Declare NSString globals as NSString * const. * Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.h: * Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm: * Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMockInternal.h: Make m_core const and initialize it with lazyInitialize(). * Source/WebKitLegacy/mac/WebView/WebFullScreenController.h: * Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm: * Source/WebKitLegacy/mac/WebView/WebPDFView.h: * Source/WebKitLegacy/mac/WebView/WebPDFView.mm: * Source/WebKitLegacy/mac/WebView/WebTextCompletionController.h: * Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm: Use RetainPtr for owned instance variables and __weak for non-owning ones. * Source/WebKitLegacy/mac/WebView/WebIndicateLayer.h: * Source/WebKitLegacy/mac/WebView/WebIndicateLayer.mm: * Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h: Use __weak for non-owning instance variables. * Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h: * Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm: Remove unused instance variables, suppress a MemoryUnsafeCast warning for WebAVPlayerController, which mimics AVPlayerController without subclassing it, and use protect() at call sites. * Source/WebKitLegacy/mac/WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]): Read layerHostingView after creating it. Also use protect(), smart pointer locals and checked Objective-C casts. * Source/WebKitLegacy/mac/WebView/WebDataSource.mm: * Source/WebKitLegacy/mac/WebView/WebDelegateImplementationCaching.mm: * Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm: * Source/WebKitLegacy/mac/WebView/WebFrame.mm: * Source/WebKitLegacy/mac/WebView/WebFrameView.mm: * Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm: * Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm: * Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: * Source/WebKitLegacy/mac/WebView/WebScriptDebugger.mm: * Source/WebKitLegacy/mac/WebView/WebView.mm: Use protect(), smart pointer locals, downcast<> and checked Objective-C casts. * Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/NoUncountedMemberCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations: * Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
cdumez
force-pushed
the
326054_WebKitLegacy_safer_cpp
branch
from
October 2, 2026 09:31
858570e to
358eab5
Compare
Collaborator
|
EWS run on current version of this PR (hash 358eab5) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
358eab5
358eab5