Skip to content

Remove WKWebProcessPlugInFormDelegatePrivate - #75629

Open
achristensen07 wants to merge 1 commit into
WebKit:mainfrom
achristensen07:eng/Remove-WKWebProcessPlugInFormDelegatePrivate
Open

achristensen07 wants to merge 1 commit into
WebKit:mainfrom
achristensen07:eng/Remove-WKWebProcessPlugInFormDelegatePrivate

Conversation

@achristensen07

@achristensen07 achristensen07 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

082e91c

Remove WKWebProcessPlugInFormDelegatePrivate
https://bugs.webkit.org/show_bug.cgi?id=326044
rdar://188974601

Reviewed by NOBODY (OOPS!).

Its last use was removed in rdar://188745131

Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKInputDelegate.mm

* Source/WebKit/Headers.cmake:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Removed.
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _formDelegate]):
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
* Tools/TestWebKitAPI/PlatformCocoa.cmake:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegate.mm: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegatePlugIn.mm: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegateProtocol.h: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKInputDelegate.mm:
(TEST(WebKit, FormSubmission)):
(TEST(WebKit, FormSubmissionLegacyAPI)):

082e91c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ❌ 🛠 ios-apple
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🧪 api-wpe ✅ 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
❌ 🛠 vision ❌ 🧪 gtk-wk2
❌ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
❌ 🧪 vision-wk2 ⏳ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=326044
rdar://188974601

Reviewed by NOBODY (OOPS!).

Its last use was removed in rdar://188745131

Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKInputDelegate.mm

* Source/WebKit/Headers.cmake:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Removed.
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _formDelegate]):
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
* Tools/TestWebKitAPI/PlatformCocoa.cmake:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegate.mm: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegatePlugIn.mm: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/BundleFormDelegateProtocol.h: Removed.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/_WKInputDelegate.mm:
(TEST(WebKit, FormSubmission)):
(TEST(WebKit, FormSubmissionLegacyAPI)):
@achristensen07 achristensen07 self-assigned this Oct 2, 2026
@achristensen07 achristensen07 added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Oct 2, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merging-blocked Applied to prevent a change from being merged WebKit API For issues and bugs in the Web Kit public embedding APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants