Skip to content

iOS: Safari sometimes crashes under -[NSISEngine removeConstraintWithMarker:] when focusing a text field - #75627

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
whsieh:eng/326039
Oct 2, 2026
Merged

webkit-commit-queue merged 1 commit into
WebKit:mainfrom
whsieh:eng/326039

Conversation

@whsieh

@whsieh whsieh commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

4bc4dba

iOS: Safari sometimes crashes under -[NSISEngine removeConstraintWithMarker:] when focusing a text field
https://bugs.webkit.org/show_bug.cgi?id=326039
rdar://165055569

Reviewed by Abrar Rahman Protyasha.

This is a speculative fix for a crash under autolayout code, triggered by unsatisfiable constraints
in `WKFormAccessoryView`; mitigate this by relaxing the top/bottom anchor constraints, such that
they're just under `required` priority.

* Source/WebKit/UIProcess/ios/forms/WKFormAccessoryView.mm:
(-[WKFormAccessoryView initWithInputAssistantItem:delegate:]):

Canonical link: https://commits.webkit.org/322496@main

fcd67d4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🧪 jsc-wpe
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk3-gcc
⏳ 🛠 ios-safer-cpp   🧪 mac-AS-debug-wk2   🛠 gtk
✅ 🛠 vision   🧪 mac-wk2-stress   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-intel-wk2   🧪 api-gtk
✅ 🛠 🧪 unsafe-merge   🧪 vision-wk2 ⏳ 🛠 mac-safer-cpp   🛠 playstation
  🛠 tv   🧪 mac-site-isolation
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@whsieh
whsieh requested a review from cdumez as a code owner October 2, 2026 02:33
@whsieh whsieh self-assigned this Oct 2, 2026
@whsieh whsieh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Oct 2, 2026
@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Oct 2, 2026
@whsieh

whsieh commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!

@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

No reviewer information in commit message, blocking PR #75627. Details: Build #42692

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Oct 2, 2026
@whsieh whsieh removed the merging-blocked Applied to prevent a change from being merged label Oct 2, 2026
@whsieh whsieh added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 2, 2026
…Marker:] when focusing a text field

https://bugs.webkit.org/show_bug.cgi?id=326039
rdar://165055569

Reviewed by Abrar Rahman Protyasha.

This is a speculative fix for a crash under autolayout code, triggered by unsatisfiable constraints
in `WKFormAccessoryView`; mitigate this by relaxing the top/bottom anchor constraints, such that
they're just under `required` priority.

* Source/WebKit/UIProcess/ios/forms/WKFormAccessoryView.mm:
(-[WKFormAccessoryView initWithInputAssistantItem:delegate:]):

Canonical link: https://commits.webkit.org/322496@main
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 322496@main (4bc4dba): https://commits.webkit.org/322496@main

Reviewed commits have been landed. Closing PR #75627 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit 4bc4dba into WebKit:main Oct 2, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants