[cleanup] Rename IntrinsicLogicalHeightComputationScope to OrthogonalIntrinsicContributionLayoutScope - #75626
Open
Conversation
…IntrinsicContributionLayoutScope https://bugs.webkit.org/show_bug.cgi?id=326042 <rdar://problem/188970306> Reviewed by NOBODY (OOPS!). IntrinsicLogicalHeightComputationScope marks an orthogonal box laid out only to give its container an intrinsic inline-size contribution, so its own percentage min/max-height follows the cyclic percentage rules. Its name suggested a general intrinsic block-size measurement, the counterpart of an intrinsic width computation, which it is not. * Source/WebCore/page/LocalFrameViewLayoutContext.cpp: (WebCore::LocalFrameViewLayoutContext::addOrthogonalIntrinsicContributionLayout): (WebCore::LocalFrameViewLayoutContext::removeOrthogonalIntrinsicContributionLayout): (WebCore::LocalFrameViewLayoutContext::isInOrthogonalIntrinsicContributionLayout const): (WebCore::LocalFrameViewLayoutContext::addIntrinsicLogicalHeightComputationFor): Deleted. (WebCore::LocalFrameViewLayoutContext::removeIntrinsicLogicalHeightComputationFor): Deleted. (WebCore::LocalFrameViewLayoutContext::isComputingIntrinsicLogicalHeightFor const): Deleted. * Source/WebCore/page/LocalFrameViewLayoutContext.h: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::computeLogicalHeight const): (WebCore::RenderBox::computeIntrinsicLogicalHeight): * Source/WebCore/rendering/RenderLayoutState.cpp: (WebCore::OrthogonalIntrinsicContributionLayoutScope::OrthogonalIntrinsicContributionLayoutScope): (WebCore::OrthogonalIntrinsicContributionLayoutScope::~OrthogonalIntrinsicContributionLayoutScope): (WebCore::IntrinsicLogicalHeightComputationScope::IntrinsicLogicalHeightComputationScope): Deleted. (WebCore::IntrinsicLogicalHeightComputationScope::~IntrinsicLogicalHeightComputationScope): Deleted. * Source/WebCore/rendering/RenderLayoutState.h:
alanbaradlay
added
the
New Bugs
Collaborator
|
EWS run on current version of this PR (hash d453a6a) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d453a6a
d453a6a
🧪 api-wpe