Skip to content

Directize: Handle table.grow #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 7 commits into from
May 5, 2026
Merged

Directize: Handle table.grow #8671

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65d3cdf
fix
kripken May 4, 2026
92d3689
format
kripken May 4, 2026
3168533
clan
kripken May 4, 2026
0f7d10c
clan
kripken May 4, 2026
13b3c4b
clan
kripken May 4, 2026
bf6eaaa
add a comment
kripken May 4, 2026
7200272
feedback
kripken May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@kripken
kripken committed May 4, 2026
commit 92d3689a87ed4abf584aaff76760e2eb4288ffec
8 changes: 4 additions & 4 deletions src/ir/table-utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ TableInfoMap computeTableInfo(Module& wasm, bool initialContentsImmutable) {
// Miniature form of TableInfo, without things we don't need (some of which
// cause compilation errors on the copies below).
struct MiniTableInfo {
// Whether the table may be modified at runtime, either because it is imported
// or exported, or table.set operations exist for it in the code.
// Whether the table may be modified at runtime, either because it is
// imported or exported, or table.set operations exist for it in the code.
bool mayBeModified = false;

// Whether the table may grow. Growing does modify the table, but it only
// appends, so we track this separately from mayBeModified, which allows more
// optimizations in tables that grow but have no other sets.
// appends, so we track this separately from mayBeModified, which allows
// more optimizations in tables that grow but have no other sets.
bool mayGrow = false;
};

Expand Down