Skip to content

Disable wide arithmetic in fuzzers #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenfontanella merged 2 commits into from
May 1, 2026
Merged

Disable wide arithmetic in fuzzers #8663

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d38659
Exclude wide-arithmetic.wast from fuzzer
stevenfontanella Apr 30, 2026
450926e
Update
stevenfontanella Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Exclude wide-arithmetic.wast from fuzzer
  • Loading branch information
@stevenfontanella
stevenfontanella committed Apr 30, 2026
commit 6d38659b1ff70c4f7869d2bea0068159e4182d8d
1 change: 1 addition & 0 deletions Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Use this handy checklist to make sure your new instructions are fully supported:
- [ ] Binary writing added in src/wasm-stack.h and src/wasm/wasm-stack.cpp
- [ ] Support added in various classes inheriting OverriddenVisitor (and possibly other non-OverriddenVisitor classes as necessary)
- [ ] Support added to src/tools/fuzzing.h
- [ ] If adding tests before fuzzing support, mark the test as unfuzzable first.

@kripken kripken Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] If adding tests before fuzzing support, mark the test as unfuzzable first.
- [ ] If adding tests before fuzzing support, mark the test as unfuzzable first, or the feature as not supported in v8 (`DISALLOWED_FEATURES_IN_V8`).

@stevenfontanella stevenfontanella Apr 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased this and mentioned DISALLOWED_FEATURES_IN_V8.

- [ ] C API support added in src/binaryen-c.h and src/binaryen-c.cpp
- [ ] JS API support added in src/js/binaryen.js-post.js
- [ ] C API tested in test/example/c-api-kitchen-sink.c
Expand Down
2 changes: 2 additions & 0 deletions scripts/test/fuzzing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@
'js_interop_counter.wat',
'js_interop_cases.wat',
'js_interop_corners.wat',
# Requires --enable-wide-arithmetic and not yet ready in V8.
'wide-arithmetic.wast',
]


Expand Down
Loading