Skip to content

[wasm-split] Move exclusive items to secondary modules #8441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aheejin merged 7 commits into from
Mar 18, 2026
Merged

[wasm-split] Move exclusive items to secondary modules #8441

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a9f9b3
[wasm-split] Move exclusive items to secondary modules
aheejin Feb 26, 2026
9c2c89f
Apply suggestions from code review
aheejin Mar 16, 2026
98b2064
Clarify primary exports in comment
aheejin Mar 16, 2026
25b072d
if-else -> switch
aheejin Mar 16, 2026
48d595e
inPrimary -> usedInPrimary
aheejin Mar 16, 2026
4f977ff
clang-format. switches are indented..?
aheejin Mar 16, 2026
aef44ba
Merge branch 'main' into wasm_split_global
aheejin Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify primary exports in comment
  • Loading branch information
@aheejin
aheejin committed Mar 16, 2026
commit 98b20648bd88362dc54746b44bef01020d53c384
4 changes: 3 additions & 1 deletion src/ir/module-splitting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,9 @@ void ModuleSplitter::shareImportableItems() {
used.tables.insert(segment->table);
}
}
// If primary module has exports, they are "used" in it

// If primary module has exports, they are "used" in it. Secondary modules
// don't have exports, so this only applies to the primary module.
for (auto& ex : module.exports) {
if (ex->kind == ExternalKind::Global) {

@tlively tlively Mar 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a switch (ex->kind) so the compiler will force us to handle new kinds of exports in the future.

@aheejin aheejin Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 25b072d

used.globals.insert(*ex->getInternalName());
Expand Down