[ELF] Reject out-of-bounds ELF sections and header tables - #8612
Merged
Merged
Conversation
plafosse
approved these changes
Oct 1, 2026
Validate the complete table against the file size using overflow-safe arithmetic. This prevents truncated tables from creating thousands of invalid, overlapping sections and stalling section-map construction.
Validate section offsets and sizes with overflow-safe bounds checks before storing or processing sections. This prevents malformed sections from triggering excessive string typing and section-map construction. Exempt SHT_NULL and SHT_NOBITS, which have no file-backed contents.
zznop
force-pushed
the
test_fix_elf_parsing_bugs
branch
from
October 2, 2026 14:22
e299129 to
cd6705d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two bounds checks:
I have validated these fixes against the binaries in this archive (which hang on 6.1):
binja-elf-hangs.zip
I have also tested all binaries in the user-provided archive:
tangential storm travels capablyCloses https://github.com/Vector35/binaryninja/issues/1593