Keyboard access: regions, message actions, call and gallery focus - #3450
Open
FrayxRulez wants to merge 5 commits into
Open
FrayxRulez wants to merge 5 commits into
FrayxRulez wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard half of the UnigramPlus pass: things the add-on had to invent because the app has no key for them.
What it does
WindowContextnow raises one for the window's own content once no frame has taken it. The new state is announced, since the shortcut leaves focus wherever it was.ModalPopup's save/restore — including the ordering that makes it work, restore before the popup closes — is now a sharedFocusScopethat both use.Choices you may want to change
IsItemClickEnabled="False"), so nothing was displaced.Not done, and why
Not built, not tested with a reader — the call and gallery paths especially want a run.