Skip to content

[pull] master from DefinitelyTyped:master #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 8 commits into from
Sep 28, 2026
Merged

[pull] master from DefinitelyTyped:master #1993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0036f25
🤖 Update CODEOWNERS
typescript-automation[bot] Sep 28, 2026
4644394
🤖 Merge PR #75532 [chrome] update since Chrome 153 by @erwanjugand
erwanjugand Sep 28, 2026
778c62e
🤖 Merge PR #75516 [chrome] fix chrome.runtime namespace by @erwanjugand
erwanjugand Sep 28, 2026
c8b49bb
🤖 Merge PR #75562 [chrome] Clean jsdocs by @erwanjugand
erwanjugand Sep 28, 2026
158fc26
🤖 Merge PR #75414 [react-virtualized] Make columnIndex optional in Ce…
Viktor-Kolyshkin Sep 28, 2026
ceadb79
🤖 Merge PR #75568 [chrome] fix chrome.printerProvider.onGetCapability…
erwanjugand Sep 28, 2026
4dda30b
🤖 Merge PR #75564 [multer] add fieldArrayIndexLimit limit option by @…
takaram Sep 28, 2026
f5d74d9
🤖 Merge PR #75619 feat(truncate-middle): remove types by @hkleungai
hkleungai Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🤖 Merge PR DefinitelyTyped#75414 [react-virtualized] Make columnIndex… 
… optional in CellMeasurerCache.getHeight/getWidth by @Viktor-Kolyshkin
  • Loading branch information
@Viktor-Kolyshkin
Viktor-Kolyshkin authored Sep 28, 2026
commit 158fc26d61d862a7d9a14b5c9c267d5b80dcd144
4 changes: 2 additions & 2 deletions types/react-virtualized/dist/es/CellMeasurer.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export class CellMeasurerCache implements CellMeasurerCacheInterface {
readonly defaultWidth: number;
hasFixedHeight(): boolean;
hasFixedWidth(): boolean;
getHeight(rowIndex: number, columnIndex: number): number;
getWidth(rowIndex: number, columnIndex: number): number;
getHeight(rowIndex: number, columnIndex?: number): number;
getWidth(rowIndex: number, columnIndex?: number): number;
has(rowIndex: number, columnIndex: number): boolean;
rowHeight: (params: { index: number }) => number;
set(rowIndex: number, columnIndex: number, width: number, height: number): void;
Expand Down
4 changes: 4 additions & 0 deletions types/react-virtualized/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
{
"name": "Adam Zmenak",
"githubUsername": "azmenak"
},
{
"name": "Viktor Kolyshkin",
"githubUsername": "Viktor-Kolyshkin"
}
]
}
8 changes: 8 additions & 0 deletions types/react-virtualized/react-virtualized-tests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,3 +1810,11 @@ export class GridCellRangeRendererExample extends PureComponent<{}, any> {
return renderedCells;
}
}

// CellMeasurerCache.getHeight / getWidth: columnIndex is optional (the library
// defaults it to 0), matching CellMeasurerCacheInterface. Common for single-column List/Table.
const singleColumnMeasurerCache = new CellMeasurerCache({ fixedWidth: true });
const measuredRowHeight: number = singleColumnMeasurerCache.getHeight(0);
const measuredRowWidth: number = singleColumnMeasurerCache.getWidth(0);
const measuredCellHeight: number = singleColumnMeasurerCache.getHeight(0, 1);
const measuredCellWidth: number = singleColumnMeasurerCache.getWidth(0, 1);