refactor(core): use the new position helpers in the keyboard shortcuts - #3101

Three follow-ups on top of #3051, all behaviour-preserving. Based on that branch, so the diff is just these changes.

1. tableContentCaretPos no longer escapes the module

Both callers in KeyboardShortcutsExtension checked contentKind === "table" themselves and then called the table helper — re-making the decision blockEdgePos already makes:

if (info.contentKind === "table") {
  ...setTextSelection(tableContentCaretPos(info.content, "end"))
} else if (info.contentKind === "none") {
  ...setNodeSelection(info.content.beforePos)
} else {
  ...setTextSelection(info.content.afterPos - 1)
}

All three arms are blockEdgePos, whose non-table path returns exactly contentStart / contentEnd. Each site is now one call plus the null case — content with no caret, i.e. an image — which is the only thing the helper can't decide for you. The +4 table offset is back to living in one place instead of three, and the function is module-private again.

2. The keyboard shortcuts use contentStart / contentEnd

BlockInfo gained those fields in #3051 precisely so callers stop writing the arithmetic, but this file still did it by hand in twelve places (content.beforePos + 1, content.afterPos - 1) — every one a "is the caret at the start/end of this block's content?" check.

Replacing them turned out to make content unused in five of the destructures, so those shrank too:

const { block, content, contentStart } = blockInfo;   →   const { block, contentStart } = blockInfo;

3. A comment on getInsertionPos's lazy-blockGroup branch

Reading if (!info.children) it isn't obvious why hardcoding wrapIn: blockGroup is safe, or why hasContent is tested when it can't be false. Both follow from the BlockInfo union — the container arm makes children required, so only a regular block reaches that branch, and the hasContent test is there to narrow the union so content can be read. The comment says so.

Verification

Behaviour-preserving, checked against both main and #3051 with two differential harnesses — identical scenarios run on each branch and the outputs diffed:

Plus core 796, multi-column 82, tests 908, type-aware lint clean.

Net −56 / +39 across the two files.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved Backspace and Delete behavior at block boundaries.
  • Caret repositioning now works more consistently across text selections, node selections, tables, empty content, and inline content.

• Refactor

  • Simplified internal handling of block-edge positions without changing block editing commands or overall shortcut behavior.