Remove stale heap positions after deleting the last item - #15487
Closed
dhairyajangir wants to merge 1 commit into
Closed
dhairyajangir wants to merge 1 commit into
dhairyajangir wants to merge 1 commit into
Conversation
7 of 15 tasks
Multiple Pull Request Detected@dhairyajangir, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code. This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation. User opened pull requests (including this one): #15487, #15486, #15485, #15484, #15483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Deleting the last active heap item removes its position entry, then immediately recreates that same entry while recording the moved item. A subsequent deletion of the supposedly absent key can remove a newly inserted, unrelated item:
Remove the deleted key after updating the moved item's position. This preserves the index map for both last-slot and interior deletions without changing the heap's storage or ordering behavior.
Validation on free-threaded CPython 3.15.0rc2:
pre-commit run --all-files --show-diff-on-failure: passed.Existing tests are unchanged, following the instruction against changing algorithm code and doctests together. This original change was prepared with AI assistance and independently reviewed.
Checklist