Conversation
kevinheald54-cloud
approved these changes
Nov 15, 2025
|
|
||
| extension JSONSubscriptType where Self: RawRepresentable<Int> { | ||
| public var jsonKey: JSONKey { | ||
| return JSONKey.index(rawValue) |
There was a problem hiding this comment.
We can add handle negative rawValue, else it might crash at run time.
Author
There was a problem hiding this comment.
I don't think we need to handle negative rawValue, which is the same as Swift.Array, and it should crash when using negative rawValue as indices.
Author
There was a problem hiding this comment.
In other words, the caller should know that negative rawValue cannot be used here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: