Skip to content

[Fix] Panic when using npm start on OSX fresh dev setup. Resolves #1017. #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakejarrett merged 4 commits into from
Jan 5, 2018
Merged

[Fix] Panic when using npm start on OSX fresh dev setup. Resolves #1017. #1016

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
349d2c4
[Fix] Panic when using npm start on OSX - fresh dev setup.
JackMordaunt Oct 6, 2017
cb57908
Refactored for clarity.
JackMordaunt Jan 3, 2018
626d441
Use method in favour of commented block.
JackMordaunt Jan 3, 2018
cf0ae2e
Typo fix.
JackMordaunt Jan 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use method in favour of commented block.
  • Loading branch information
@JackMordaunt
JackMordaunt committed Jan 3, 2018
commit 626d4419b10e13708514d53a5d8860eca4042385
25 changes: 14 additions & 11 deletions app/public/js/common/configLocation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ const configuration = {
});
},

createIfNotExist(path) {
try {
const pathInfo = fs.statSync(path);
if (!pathInfo.isDirectory()) {
this.createUserConfig(path);
}
}
catch(error) {
this.createUserConfig(path);
}
},

/**
* Get the configuration folder location
*
Expand Down Expand Up @@ -42,17 +54,8 @@ const configuration = {
throw `could not set config path for this OS ${process.platform}`
}

// create user config in path
// if there is no userConfig path
try {
const configFileInfo = fs.statSync(userConfigPath);
if (!configFileInfo.isDirectory()) {
this.createUserConfig(userConfigPath);
}
}
catch(error) {
this.createUserConfig(userConfigPath);
}
createIfNotExist(userConfigPath)

return userConfigPath;
},

Expand Down