Repository navigation
fixed: Missing folder structure in html output #50 - #65
Conversation
Current coverage is 99.25%@@ master #65 diff @@
==========================================
Files 9 9
Lines 395 402 +7
Methods 0 0
Messages 0 0
Branches 15 15
==========================================
+ Hits 385 399 +14
+ Misses 5 3 -2
+ Partials 5 0 -5
|
|
@kitsonk is it possible to merge this pull request in the next days? or is there a reason why it takes so long? |
|
I just tried the patch with a webpack bundle of several unit tests plus supporting code and it generates an invalid It then throws an error when |
|
hey @bryanforbes, can you provide an example of your setup? does remap work as expected without my patch or do you also have the issue #50 ? |
|
Could this be related? |
|
@delasteve @bryanforbes the problem was a missing file extension. I fixed that bug but I did not fix #68 . But I have a working setup to fix #68 . Maybe I will make another PR if I have enough time this weekend. |
|
I'd like to see this merged in, too, since we're currently referencing @devCrossNet's fork. |
| /* if there are inline sources and a store to put them into, we will populate it */ | ||
| var inlineSourceMap = {}; | ||
| if (sourceMap.sourcesContent) { | ||
| var origSourceFilename = rawSourceMap.sources[0], |
There was a problem hiding this comment.
You should declare the variables outside of the if block for consistency.
There was a problem hiding this comment.
I'll change that asap
|
@bryanforbes Any chance you could take a look at this again? |
|
@devCrossNet Thanks for your work here, looks great! |
|
you're welcome |
|
@jdonaghue can you tell me in which version this fix will be released? and when? regards |
I hope the changes will solve the issue: Missing folder structure in html output #50