Add ruff unsafe fixes

t-sommer · Jun 3, 2025 · Jun 2, 2025 · Jun 2, 2025 · Jun 2, 2025 · Jun 2, 2025
commit 5d299e76903f06a098df9a237a016dee458b3f31
diff --git a/src/sdf/dsres.py b/src/sdf/dsres.py
@@ -3,8 +3,10 @@
 import scipy.io
 
 # extract strings from the matrix
-strMatNormal = lambda a: [''.join(s).rstrip() for s in a]
-strMatTrans = lambda a: [''.join(s).rstrip() for s in zip(*a)]
+def strMatNormal(a):
+    return [''.join(s).rstrip() for s in a]
+def strMatTrans(a):
+    return [''.join(s).rstrip() for s in zip(*a)]
 
 
 def _split_description(comment):

diff --git a/src/sdf/plot/contour_plot_3d.py b/src/sdf/plot/contour_plot_3d.py
@@ -29,8 +29,6 @@ def create_plot(filename, datasets):
     figure = plt.figure(figsize=(12, 8))
     figure.patch.set_facecolor('white')
 
-    nrows = len(datasets)
-
     for row, dataset in enumerate(datasets):
 
         # load the datasets
@@ -78,7 +76,7 @@ def create_plot(filename, datasets):
             ax.set_title(scale3.display_name + "=" + ("%g" % scale3.data[i]) + " " + scale3.unit)
             ax.set_xlabel(C1.scales[1].display_name + " / " + C1.scales[1].unit)
 
-        cbar = figure.colorbar(CSF)
+        figure.colorbar(CSF)
 
     plt.tight_layout()
 

diff --git a/tests/test_sdf.py b/tests/test_sdf.py
@@ -132,7 +132,7 @@ def test_hierarchy(self):
         sdf.save('roundtrip.sdf', g)
 
         # load the group from the file        
-        g2 = sdf.load('roundtrip.sdf', '/')
+        sdf.load('roundtrip.sdf', '/')
 
         # TODO: compare the objects
         #self.assertEqual(pickle.dumps(g), pickle.dumps(g2))