Repository navigation
Fix pytest skipped test grading - #598
yinli-systems wants to merge 2 commits into
Conversation
Signed-off-by: Kevin-Li-2025 <2242139@qq.com>
Signed-off-by: Kevin-Li-2025 <kxl474@student.bham.ac.uk>
2d1d7c2 to
ad89568
Compare
|
@john-b-yang @klieret this is now rebased onto current |
|
will take a look soon thank you! |
|
Merged as a5ecda6 (reimplemented against current main, with your authorship on the commit; #611/#617/#279 landed today and conflicted with all three files here, so this doesn't auto-close). Your grading change turns out to close a real scoring exploit, which I don't think the issue title conveys: on the previous semantics a skipped test landed in neither the success nor the failure list, so a patch that made every FAIL_TO_PASS test skip produced I kept your semantics exactly (SKIPPED in Two changes from your version:
I also dropped the Gold eval unchanged across all three datasets (Verified 500/500, Multilingual 298/300, Multimodal 483/483). Also worth noting for scope: 0 instances in any dataset currently have a SKIPPED F2P or P2P test, so the semantics change is a no-op for gold and matters only for model grading. Added 6 tests including the all-skipped regression. Thanks — good catch on SWE-bench/sb-cli#29. |
|
^claude generated summary that i reviewed, thanks so much for this catch! this was a real issue, doesn't affect gold evaluation but you're totally right this would've marked certain errant submissions as correct. tysm! |
Summary
nodeid SKIPPED ...result lines so skipped tests retain their real node ID.SKIPPED [N] path:line: reasonsummary lines instead of recording[N]as a fake test.mainafter the harness restructure.Fixes SWE-bench/sb-cli#29.
Validation
python -m pytest -vv tests/test_log_parsers_python.py tests/test_grading.py— 7 passed.python -m pytest --cov -k "not test_one_instance"— 20 passed, 1 deselected.pre-commit run --files swebench/harness/grading.py swebench/harness/log_parsers/python.py tests/test_grading.py tests/test_log_parsers_python.py— ruff and ruff-format passed.git diff --check upstream/main...HEAD.The deselected repository test is the network-backed gold evaluation for
sympy__sympy-20590. It reached the remote dataset request but stalled in a TLS handshake on this macOS host; PR CI remains the authoritative run for that external evaluation path.