Skip to content

fix(fabric): Alter table workaround #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erindru merged 13 commits into from
Dec 2, 2025
Merged

fix(fabric): Alter table workaround #5511

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
acfeea0
feat: implement no-op alter_table method for FabricEngineAdapter
fresioAS Oct 8, 2025
445c775
proper test
fresioAS Oct 8, 2025
fa0fdc6
cosmetics on descriptions
fresioAS Oct 8, 2025
f0acd3b
ruff
fresioAS Oct 8, 2025
7cdbf81
add new column, copy to new column, drop original column, rename new …
fresioAS Oct 23, 2025
40ec146
Merge branch 'main' into fabric_alter_table_no_op
fresioAS Oct 23, 2025
2607f7c
revert test deleted by accident
fresioAS Oct 23, 2025
768716c
revert#2
fresioAS Oct 23, 2025
1835883
ruff
fresioAS Oct 23, 2025
46fe7e8
Merge branch 'main' into fabric_alter_table_no_op
fresioAS Oct 23, 2025
09d2bbd
Merge branch 'main' into fabric_alter_table_no_op
fresioAS Nov 24, 2025
ba2c888
Add extra line before test_merge_pandas function
fresioAS Nov 24, 2025
2e77993
Merge branch 'main' into fabric_alter_table_no_op
tobymao Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ruff
  • Loading branch information
@fresioAS
fresioAS committed Oct 8, 2025
commit f0acd3b6ab2484a0734000c29ae1470b2bc737b9
3 changes: 2 additions & 1 deletion sqlmesh/core/engine_adapter/fabric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from sqlmesh.utils.connection_pool import ConnectionPool
from sqlmesh.core.schema_diff import TableAlterOperation


logger = logging.getLogger(__name__)


Expand Down Expand Up @@ -160,7 +161,7 @@ def alter_table(
) -> None:
"""
Disables ALTER TABLE for Fabric since it has limited support.
By making this a no-op, we signal to the caller to fall back to a
By making this a no-op, we signal to the caller to fall back to a
more reliable drop/add strategy for columns to apply schema changes.
"""
return
Expand Down