Skip to content

Initialize PyRef marker in native base conversion - #9096

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/pyref-native-base-marker
Oct 13, 2026
Merged

Initialize PyRef marker in native base conversion#9096
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/pyref-native-base-marker

Conversation

@youknowone

@youknowone youknowone commented Oct 13, 2026

Copy link
Copy Markdown
Member

Summary

Initialize the required marker: PhantomData field when PyRef::into_base constructs its result.

The initializer introduced by #9090 at main 0803a55 currently constructs PyRef { ptr }, but PyRef requires both ptr and marker. This produces E0063 in the #9094 merge-ref build (f2c9b285 into 0803a55):

https://github.com/RustPython/RustPython/actions/runs/38397174305/job/115295246184

This is a one-initializer correction. The pointer cast, ownership transfer, native-base semantics, and tests are unchanged.

Validation

  • Independent source review and normal hooks passed.
  • Linux threading VM compile-only check and strict Clippy (-D warnings): passed.
  • No new cast/layout or concurrency runtime probe was executed.
  • Existing hosted CI will validate the repaired main-based source.

@youknowdot
Initialize PyRef marker in native base conversion
85f3ecd 
Fix the missing field in the new into_base initializer without changing its pointer or ownership transfer.

Assisted-by: OpenAI Codex: model identifier unavailable
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cad80196-2e68-4476-bcd6-939d26c2f104
📥 Commits

Reviewing files that changed from the base of the PR and between 0803a55 and 85f3ecd.

📒 Files selected for processing (1)
  • crates/vm/src/object/core.rs
 ________________________________________________________
< Code review is a dish best served cold. Like a carrot. >
 --------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowone
youknowone marked this pull request as ready for review October 13, 2026 12:58
@youknowone
youknowone merged commit 723dee0 into RustPython:main Oct 13, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T12:59:43.837425Z 85f3ecd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@youknowone youknowone mentioned this pull request Oct 13, 2026
Draft
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowone @youknowdot