Repository navigation
Canonicalize nested template format specs in annotations - #9076
Merged
youknowone merged 1 commit intoOct 11, 2026
Merged
Conversation
Use the existing f-string body unparser for template interpolation format specs, while preserving the outer interpolation source text. Add compile-only Python annotation-constant coverage. Assisted-by: OpenAI Codex:model identifier unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
youknowone
approved these changes
Oct 11, 2026
youknowone
marked this pull request as ready for review
October 11, 2026 00:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the independent template format-spec unparse correction from #8954. Interpolation format specs contain ordinary formatted-value fields and must use the existing f-string body unparser. The outer template interpolation continues to preserve its source spelling.
For example, a future annotation containing
t'{value:{(width)}}'is canonically stored ast'{value:{width}}'. This one-line dispatch fix matches CPython 3.14.7 and 3.14.8.No broader interpolation text, debug-comment, or newline reconstruction changes are included. Checked adjacent #8160 and other open codegen work; this is the separate format-spec dispatch.
Validation
test_unparse.UnparseTestCase.test_tstringsand existing structural future-template annotation test pass.The regression only compiles and inspects annotation constants; it never executes the generated annotation or formatting callbacks. Local validation is Linux; the full hosted matrix remains required.